DYN-6857-homepage-preferences#15139
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Apr 16, 2024
Merged
Conversation
- added a single serialized preferences storage for the HomePage
…-gridlist-persistence
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Contributor
|
Oops, I think I accidentally merged the wrong PR.. Will review now and depends on the result, we can see how to follow up |
QilongTang
reviewed
Apr 16, 2024
| /// <summary> | ||
| /// Persistence for Dynamo HomePage | ||
| /// </summary> | ||
| [XmlIgnore] |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Apr 16, 2024
This reverts commit 534f6cf.
9 tasks
reddyashish
added a commit
that referenced
this pull request
Apr 16, 2024
Contributor
|
@dnenov Would you re-propose this PR? |
Collaborator
|
I will create a new PR for this one as Deyan is going on leave. |
Contributor
Thank you, appreciate it! |
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
May 14, 2024
- added a single serialized preferences storage for the HomePage (cherry picked from commit 534f6cf)
9 tasks
reddyashish
added a commit
that referenced
this pull request
May 15, 2024
Co-authored-by: Deyan Nenov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses a jira request for improvement of the HomePage:
As a Dynamo user, I want Grid/List view option picked on Dynamo Home persist across sessionshttps://jira.autodesk.com/browse/DYN-6857.Works with the following HomePage changes: DynamoDS/DynamoHome#13
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@Amoursol
FYIs
@reddyashish