Merged
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
- IsAxesVisible is now internal. - Extra summary to color properties. - Ensure that aces and grids are visible before Assert visibility in test.
IsAxesVisible removed
Contributor
|
Awesome, thanks so much @ivaylo-matov 🤩 |
Contributor
|
Which Jira task does this belong? |
QilongTang
approved these changes
Apr 16, 2024
Contributor
Author
|
@QilongTang , It doesn't have a ticket. This is something Sol and Deyan have been discussing. |
reddyashish
approved these changes
Apr 29, 2024
QilongTang
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Small PR to hide/show Axes from HelixWatch3D when the Grid is hidden/shown as well.
Including test.
Before
After
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Hide/show Axes from HelixWatch3D when the Grid is hidden/shown.
Including test.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol