DYN-4344 hotkey to unpin all node previews#15117
DYN-4344 hotkey to unpin all node previews#15117QilongTang merged 15 commits intoDynamoDS:masterfrom
Conversation
without hotkey some code might be redundant
all working
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
This is awesome :D Thanks so much @ivaylo-matov |
avidit
changed the title
|
LGTM with one comment. |
|
@pinzart90 Were you trying to merge master into this branch, to solve the regression reported? |
Yes, but the problem still persists. It is actually caused by the new test. I am working on a fix and will push to this PR |
|
sorry for the delay... looking into it now. seem like the new test is causing the next two test to fail regardless of the order. All run okay if I move it last, but I assume this won't be acceptable? |
UnpinPreviewBubble() was not updating the nodeViewModel
|
hopefully the last commit will solve this regression 🤞 |
|
The failing test here is from GNM test suite [DynamoCoreWpfTests.GraphNodeManagerViewExtensionTests.ContainsEmptyListOrNullTest] which is flaky. @QilongTang good to merge this? |
Good point, This one should be good to go from the last Dynamo Self Serve run, merging. |
5 participants
Purpose
Added functionality to unpin and collapse all preview bubbles. Implementation of menu item and hotkey (CTRL + K) to trigger the command.
Test also included.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Added functionality to unpin and collapse all preview bubbles. Implementation of menu item and hotkey (CTRL + K) to trigger the command.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol