Skip to content

Dyn 6821 home page links fix#15098

Merged
QilongTang merged 7 commits intoDynamoDS:masterfrom
dnenov:DYN-6821-HomePage-links-fix
Apr 9, 2024
Merged

Dyn 6821 home page links fix#15098
QilongTang merged 7 commits intoDynamoDS:masterfrom
dnenov:DYN-6821-HomePage-links-fix

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 8, 2024 •
edited
Loading

Purpose

Addresses this Jira issue: DYN-6821 Fixes HomePage links.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixes homepage links
  • this was broken during the drag&drop implementation

Reviewers

@reddyashish

FYIs

@Amoursol

@dnenov dnenov requested a review from reddyashish April 8, 2024 17:16
@QilongTang
Copy link
Contributor

QilongTang commented Apr 9, 2024

Sorry @dnenov I think our team rebased master branch so your DYN-6821-HomePage-links-fix had the wrong base branch and contained changes unintended for master now, would you rebase your changes?

@dnenov
Copy link
Collaborator Author

dnenov commented Apr 9, 2024

Sorry @dnenov I think our team rebased master branch so your DYN-6821-HomePage-links-fix had the wrong base branch and contained changes unintended for master now, would you rebase your changes?

Thanks for the heads up @QilongTang ! Reverted the changes in both my affected PRs

@QilongTang
Copy link
Contributor

QilongTang commented Apr 9, 2024

hi @dnenov I think you still have a few deletion change needs to be reverted

reddyashish
reddyashish reviewed Apr 9, 2024
View reviewed changes
src/Libraries/DSOffice/Properties/Resources.resx
@@ -1,123 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

@reddyashish reddyashish Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these resources not used anymore?

Copy link
Contributor

@QilongTang QilongTang Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes came from a revert change by Roberto earlier but I had to force push to wipe it so causing some confusion here. They are not meant to be included in the PR

Copy link
Collaborator Author

@dnenov dnenov Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I missed those .. I'm sorry guys.

@github-actions
Copy link

github-actions bot commented Apr 9, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Apr 9, 2024
@QilongTang QilongTang merged commit 26f992a into DynamoDS:master Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reddyashish reddyashish reddyashish left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dnenov @QilongTang @reddyashish @RobertGlobant20