DYN-6783: Thumbnails for interactive guides#15094
Merged
QilongTang merged 12 commits intoDynamoDS:masterfrom Apr 16, 2024
Merged
DYN-6783: Thumbnails for interactive guides#15094QilongTang merged 12 commits intoDynamoDS:masterfrom
QilongTang merged 12 commits intoDynamoDS:masterfrom
Conversation
This reverts commit 765542d.
DynamoDS#15092) This reverts commit 765542d.
- added base64 img for tour guides as resources to be used as thumbnails in the HomePage
UI Smoke TestsTest: success. 2 passed, 0 failed. |
reddyashish
reviewed
Apr 8, 2024
…interactiveguide-thumbnails
Contributor
|
hi @dnenov I think you still have a few deletion change needs to be reverted in DSOffice project |
…interactiveguide-thumbnails
Collaborator
Author
Oh boy, thank you for your patience @QilongTang . |
- moved base64 image resources to the HomePage class
…interactiveguide-thumbnails
QilongTang
approved these changes
Apr 16, 2024
QilongTang
reviewed
Apr 16, 2024
| static Dynamo.Wpf.Properties.Resources.GroupStylesSaveButtonText.get -> string | ||
| static Dynamo.Wpf.Properties.Resources.HideClassicNodeLibrary.get -> string | ||
| static Dynamo.Wpf.Properties.Resources.HideWiresPopupMenuItem.get -> string | ||
| static Dynamo.Wpf.Properties.Resources.HomePageInteractiveGuideGettingStartedImg.get -> string |
Contributor
There was a problem hiding this comment.
These are private APIs so they dont need to be declared
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses https://jira.autodesk.com/browse/DYN-6783:
The following PR contains the changes in the react app to allow the correct functionality of this PR.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
FYIs
@Amoursol