DYN-6775-Localizing-SplashScreen#15065
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Apr 2, 2024
RobertGlobant20:DYN-6775-Localizing-SplashScreen
Merged
DYN-6775-Localizing-SplashScreen#15065QilongTang merged 2 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-6775-Localizing-SplashScreen
QilongTang merged 2 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-6775-Localizing-SplashScreen
Conversation
I've added some code for localizing the tooltip in the SignOut/SignIn buttons, but still won't be working until the React SplashScreen component is fixed.
Contributor
Author
|
I cannot probe this changes until the React SplashScreen component is fixed (even when the code is present the tooltip is not being updated). |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
the tooltip values in React SplashScreen had typos then I fixed also the same in Dynamo.
QilongTang
reviewed
Apr 2, 2024
| $"signInTitle: \"{Wpf.Properties.Resources.SplashScreenSignIn}\"," + | ||
| $"signInTooltip: \"{Wpf.Properties.Resources.SignInButtonContentToolTip}\"," + | ||
| $"signOutTitle: \"{Wpf.Properties.Resources.SplashScreenSignOut}\"," + | ||
| $"signOutTooltip: \"{Wpf.Properties.Resources.SignOutConfirmationDialogText}\"," + |
Contributor
There was a problem hiding this comment.
@RobertGlobant20 With the spelling change, do we still need PR on the web component side?
Contributor
Author
There was a problem hiding this comment.
yes, the property is also inconsistent in the web component, I'm still working on that fix
QilongTang
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Localizing SplashScreen Tooltip
I've added some code for localizing the tooltip in the SignOut/SignIn buttons, but still won't be working until the React SplashScreen component is fixed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Localizing SplashScreen Tooltip
Reviewers
@QilongTang
FYIs