Fix crash/freeze on systems with no AdskIdentityManager or any adsk product#15042
Merged
zeusongit merged 3 commits intoDynamoDS:masterfrom Mar 22, 2024
Merged
Fix crash/freeze on systems with no AdskIdentityManager or any adsk product#15042zeusongit merged 3 commits intoDynamoDS:masterfrom
zeusongit merged 3 commits intoDynamoDS:masterfrom
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
mjkkirschner
approved these changes
Mar 21, 2024
| return false; | ||
| } | ||
| } | ||
| return false; |
Member
There was a problem hiding this comment.
any time we return false, should we perhaps also log something to the console?
QilongTang
approved these changes
Mar 21, 2024
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Mar 22, 2024
…roduct (DynamoDS#15042) * Update IDSDKManager.cs * Update IDSDKManager.cs * add logs
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-6799
Expanded the region of try-catch to include init API that throws an exception when Dynamo is launched on clean machine with no autodesk product or no Adsk Identity Manager.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@DynamoDS/dynamo