Update LIBG 229 in 2.19.5#15029
Merged
sm6srw merged 2 commits intoDynamoDS:RC2.19.5_masterfrom Mar 21, 2024
Merged
Conversation
Member
|
@sm6srw seems like a lot of unintended changes in this PR. |
Contributor
Author
|
Oops, wrong base. Sorry. |
Contributor
|
So this version of libg contains geometryprimitives as well? |
Contributor
Author
Yes, one of the complications. |
aparajit-pratap
approved these changes
Mar 20, 2024
Contributor
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
@sm6srw did you do some manual testing on the offset issue in Dynamo with this version of libg?
Contributor
Author
Yes, I did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This will cherry-pick DYN-6043
All tests passed on master-15.
This will add two new files for the geometry primitives.
I have not seen any side effects but let me know if you think that we should skip this because it can have some unforeseen consequences.
Declarations
Just a test for now.
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of