feat: localized no-notifications message#15002
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Mar 6, 2024
Merged
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
Mar 6, 2024
Contributor
|
The new npm package v0.0.29 has been published, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR add the implementation for localized message when there's no notifications to show
Ref.: DYN-6484
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Implement message in resources
NoNotificationsTitleandNoNotificationsMsgwith respective text associated and expose setNoNotificationsTexts() through Windows object to make it accessible from NotificationCenter react component.Reviewers
@QilongTang