[CherryPick] Lucene search IMP#14997
Merged
QilongTang merged 5 commits intoRC2.19.5_masterfrom Mar 5, 2024
Merged
Conversation
* improvements * Simply initialization logic * Skip indexing as part of DynamoModel if the index files already exist * Remove DynamoModel reference and use singleton * clean up * improvements and package manager search * Use single constructor and other code clean up * Update... * Update * Dispose all Lucene objects in the correct order * Adding DynamoModel back to test regressions * Null check * Update * IndexWriter dispose sequence only for non-RAM mode
* Use index writer to amend index after Dynamo Launch * Update sorting * Update * Update * Update * Make sure package loading end will already release index lock * Update Comments * Clean Up * Code clean up * clean up * Code Clean Up * regressions * revert code clean up because it affects running tests in parallel * update
QilongTang
changed the title
reddyashish
reviewed
Mar 4, 2024
| // in AssemblyVersionInfo.cs so that it can be easily incremented by the | ||
| // automated build process. | ||
| [assembly: AssemblyVersion("2.19.5.7897")] | ||
| [assembly: AssemblyVersion("2.19.5.7936")] |
Collaborator
There was a problem hiding this comment.
Remove this file commit.
reddyashish
reviewed
Mar 4, 2024
Collaborator
reddyashish
left a comment
reddyashish
left a comment
There was a problem hiding this comment.
LGTM with one comment.
RobertGlobant20
approved these changes
Mar 4, 2024
Contributor
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM, this are changes already applied in 3.0, right? This is just a cherry-pick
| // You can specify all the values or you can default the Build and Revision Numbers | ||
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyFileVersion("2.19.5.7897")] |
Contributor
There was a problem hiding this comment.
it's ok to modify this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry-picking:
#14428
#14513
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
FYIs
@DynamoDS/dynamo