DYN-6603 decrease weight for tspline nodes#14965
Merged
QilongTang merged 3 commits intoDynamoDS:masterfrom Feb 27, 2024
RobertGlobant20:DYN-6603-DecreaseWeight-TSplineNodes
Merged
DYN-6603 decrease weight for tspline nodes#14965QilongTang merged 3 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-6603-DecreaseWeight-TSplineNodes
QilongTang merged 3 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-6603-DecreaseWeight-TSplineNodes
Conversation
I've changed the weight of Spline nodes at indexing time so when using criteria like "sphere" will show first the nodes under the Sphere category and later the T-Spline nodes which has the text "sphere" in the name. For implementing the expected behavior I've decreased the weight of the fields Description and SearchKeywords just for t-spline nodes.
updating comment
Contributor
Author
|
Screenshot showing results before and after my fix: |
Contributor
Author
|
Screenshot showing results before and after my fix: |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
Feb 23, 2024
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Thanks, looks good, can you add a unit test about the order of a geometry search results?
I've added a unit test that will validate the nodes result order after searching a specific criteria which includes in the results T-Spline nodes.
Contributor
Author
@QilongTang I've added a unit test that will validate the order of nodes (when t-spline nodes were added). |
QilongTang
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Decreasing t-spline nodes weight during search so we will see nodes under a specific category at the top and later t-spline nodes.
I've changed the weight of Spline nodes at indexing time so when using criteria like "sphere" will show first the nodes under the Sphere category and later the T-Spline nodes which has the text "sphere" in the name. For implementing the expected behavior I've decreased the weight of the fields Description and SearchKeywords just for t-spline nodes.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Decreasing t-spline nodes weight during search so we will see nodes under a specific category at the top and later t-spline nodes.
Reviewers
@QilongTang @reddyashish
FYIs