DYN-6602 Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag#14923
DYN-6602 Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag#14923QilongTang merged 7 commits intomasterfrom
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
changed the title
| } | ||
| catch (Exception e) { Logger.LogError($"could not start feature flags manager {e}"); }; | ||
| }); | ||
| DynamoFeatureFlagsManager.FlagsRetrieved += HandleFeatureFlags; |
There was a problem hiding this comment.
Add feature flag event based TSpline nodes show/hide. FYI: @reddyashish @mjkkirschner
|
@QilongTang did we want to hide the entire Experimental section also if we no longer have anything inside it? i.e. - it shows if we have something, is hidden if not? |
@sm6srw is going to add paneling nodes to it. |
Agreed, I think we will have more experimental features in the future, e.g. new App home |
| internal void UpdateNamespacesToExcludeFromLibrary() | ||
| { | ||
| // When the experiment toggle is disabled by feature flag, include the TSpline namespace from the library OOTB. | ||
| if (!DynamoModel.FeatureFlags?.CheckFeatureFlag("IsTSplineNodesExperimentToggleVisible", false) ?? false) |
There was a problem hiding this comment.
Why not use preferenceSettings.IsTSplineNodesExperimentToggleVisible property here?
As far as I understand, this PR isn't doing it the way @Amoursol is suggesting. The display of the experimental expander purely depends on whether the feature flag is on or off, not on whether there are experimental features or not. I think the experimental section should be displayed based on whether |
6 participants
Purpose
DYN-6602 Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag.
Tested cases covering:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of