Address regressions related to samples#14900
Merged
QilongTang merged 1 commit intomasterfrom Jan 29, 2024
Merged
Conversation
Contributor
Author
|
@reddyashish You were right about the PR validation I guess, some how new failures were introduced because of the zoom level and view port changes :) |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
added a commit
that referenced
this pull request
Jan 29, 2024
QilongTang
added a commit
that referenced
this pull request
Jan 29, 2024
…UI fix (#14889) (#14902) * Update Dynamo sample graphs (#14897) * update dynamo sample graphs - update all dynamo-related sample graphs * fix failing tests after update - updated numerous tests after the changes * Pm AddPath button UI fix (#14889) * small visual fix - added the text part next to the icon to the button element - now the button works through either the text or the icon * added AddPath hover state - now AddPath shares the same hover state as the icon * address regressions related to samples (#14900) --------- Co-authored-by: Deyan Nenov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up of #14897 to address the remaining 3 regressions. Test results can be seen at https://master-15.jenkins.autodesk.com/job/DYN-Dynamo/job/DynamoBuildscripts/job/master/2546/
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@DynamoDS/dynamo