DYN-3844 Open Dynamo Template as new workspace#14871
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
changed the title
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM with some comments
| /// Present the open dialog and open the template that is selected. | ||
| /// </summary> | ||
| /// <param name="parameter"></param> | ||
| private void ShowOpenTemplateDialog(object parameter) |
There was a problem hiding this comment.
Any way we can combine this with ShowOpenDialogAndOpenResult ?
There was a problem hiding this comment.
yeah I thought about this but we need to call Open function below with different tuple and use TemplatesDirectory as start directory, currently there is nothing we can use to differentiate two workflows other than use different command for each menu item. I can try think about this more
| <MenuItem Header="{x:Static p:Resources.DynamoViewFileMenuOpenTemplate}" | ||
| Name="openTemplateMenuItem" | ||
| Command="{Binding ShowOpenTemplateDialogCommand}" | ||
| CommandParameter="Template" |
There was a problem hiding this comment.
@zeusongit I decided to use command param so we can distinguish if Dynamo is opening a template so we can reuse more file open code. We cant really use the same command because I think command and shortcut keys are 1:1 relationship and Open Template need its own shortcut keys.
|
Merging this PR in to create the base of template function. |
QilongTang
changed the title
3 participants
Purpose
Introduce open by template function in Dynamo.
ToDo:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of