Skip to content

DYN-6580 - fix crash when attempting to open docs browser multiple times in quick succession.#14782

Merged
mjkkirschner merged 1 commit intoDynamoDS:masterfrom
mjkkirschner:f1double
Dec 19, 2023
Merged

DYN-6580 - fix crash when attempting to open docs browser multiple times in quick succession.#14782
mjkkirschner merged 1 commit intoDynamoDS:masterfrom
mjkkirschner:f1double

Conversation

@mjkkirschner
Copy link
Member

Purpose

When the f1 hotkey is used to get docs for a node multiple times on the first initialization of the docs browser webview2 instance we can re-enter the initializeAsync function while we're still awaiting initialization. The previous logic would then go on to try to use the coreWebView object before it was initialized, now if we're not "done" we just bail. The original invocation that was still initializing will start executing and we'll show the docs browser.

a test is added.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

@mjkkirschner mjkkirschner added this to the 3.0 milestone Dec 18, 2023
@github-actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjkkirschner mjkkirschner merged commit 21b8c14 into DynamoDS:master Dec 19, 2023
@mjkkirschner mjkkirschner deleted the f1double branch December 19, 2023 19:54
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Dec 19, 2023
mjkkirschner added a commit that referenced this pull request Dec 19, 2023
* remove IronPython code and extension (#14706)

* remove legacy completion provider

* remove

* remove obsolete -arguable

tests seem to pass going to merge this and cherry pick to 3.0

* fix crash (#14782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants