DYN-6580 - fix crash when attempting to open docs browser multiple times in quick succession.#14782
Merged
mjkkirschner merged 1 commit intoDynamoDS:masterfrom Dec 19, 2023
Merged
Conversation
pinzart90
approved these changes
Dec 18, 2023
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Dec 19, 2023
mjkkirschner
added a commit
that referenced
this pull request
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When the
f1hotkey is used to get docs for a node multiple times on the first initialization of the docs browser webview2 instance we can re-enter the initializeAsync function while we're still awaiting initialization. The previous logic would then go on to try to use the coreWebView object before it was initialized, now if we're not "done" we just bail. The original invocation that was still initializing will start executing and we'll show the docs browser.a test is added.
Declarations
Check these if you believe they are true
*.resxfiles