DYN-5656 Dynamo UI Blocking Action#14778
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Jan 8, 2024
RobertGlobant20:DYN-5656-DynamoUI-Blocking-Action
Merged
DYN-5656 Dynamo UI Blocking Action#14778QilongTang merged 2 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-5656-DynamoUI-Blocking-Action
QilongTang merged 2 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-5656-DynamoUI-Blocking-Action
Conversation
I've implementing the functionality of adding the GuideBackground (overlay) when the Preferences panel or the PackageSearchWindow are opened and removing it when those windows are closed. In this way when we have the GuideBackground the user won't be able to interact with the background. I've added this functionality in the DynamoView but due that the GuideBackground is not working with the Library, I had to implement the overlay functionality in the library.html and the functions needed to set the overlay from .NET.
Contributor
Author
|
This is a GIF showing the behavior for PackageManagerSearch and Preferences panel. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Contributor
Author
|
@QilongTang @reddyashish |
QilongTang
reviewed
Jan 8, 2024
QilongTang
reviewed
Jan 8, 2024
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with one comment
Fixing Columns and Rows hardcoded values
UI Smoke TestsTest: failure. 1 passed, 1 failed. |
QilongTang
approved these changes
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I've implementing the functionality of adding the GuideBackground (overlay) when the Preferences panel or the PackageSearchWindow are opened and removing it when those windows are closed. In this way when we have the GuideBackground the user won't be able to interact with the background. I've added this functionality in the DynamoView but due that the GuideBackground is not working with the Library, I had to implement the overlay functionality in the library.html and the functions needed to set the overlay from .NET.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Implementing the functionality of adding the GuideBackground (overlay)
Reviewers
@reddyashish
FYIs
@QilongTang