Skip to content

Bump Dynamo to 3.1#14719

Merged
sm6srw merged 6 commits intoDynamoDS:masterfrom
sm6srw:bump_to_3.1
Dec 8, 2023
Merged

Bump Dynamo to 3.1#14719
sm6srw merged 6 commits intoDynamoDS:masterfrom
sm6srw:bump_to_3.1

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Dec 7, 2023

Purpose

Bump master to 3.1

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw requested a review from QilongTang December 8, 2023 00:13
@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@sm6srw sm6srw requested a review from mjkkirschner December 8, 2023 00:27
QilongTang
QilongTang reviewed Dec 8, 2023
View reviewed changes
src/AssemblySharedInfoGenerator/AssemblySharedInfo.tt Outdated
// Major Version
// Minor Version
// Version information for an assembly consists of the following four valu
// Majo//Minor Version
Copy link
Contributor

@QilongTang QilongTang Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh Typo here I think

Copy link
Contributor Author

@sm6srw sm6srw Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

QilongTang
QilongTang reviewed Dec 8, 2023
View reviewed changes
src/AssemblySharedInfoGenerator/AssemblySharedInfo.tt
<#+
int MajorVersion = 3;
int MinorVersion = 0;
int MinorVersion = 1;
Copy link
Contributor

@QilongTang QilongTang Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the year in the RevisionNumber formula as well to use 2024?

Copy link
Contributor Author

@sm6srw sm6srw Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goto 2024 will give negative numbers but we can do 2023 now and then try to remember to bump it again when we get to 3.2.

Copy link
Contributor

@QilongTang QilongTang Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks!

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@sm6srw sm6srw merged commit 42ba299 into DynamoDS:master Dec 8, 2023
@sm6srw sm6srw deleted the bump_to_3.1 branch December 8, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sm6srw @QilongTang