Pm reinstate description check#14717
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom Dec 11, 2023
Merged
Conversation
- brought back description check as publish online API still requires it
reddyashish
approved these changes
Dec 7, 2023
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: failure. 1 passed, 1 failed. |
reddyashish
approved these changes
Dec 11, 2023
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
Dec 14, 2023
- brought back description check as publish online API still requires it (cherry picked from commit d70c7b5)
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Dec 14, 2023
* remove duplicate dyf file warning from preview generation process (#14711) - dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control - this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow (cherry picked from commit 3ea1c5c) * remove package version limitation (#14716) - now allows package version to start with 0 - cannot have 0.0.0 package version (cherry picked from commit 992e54c) * reinstate description check (#14717) - brought back description check as publish online API still requires it (cherry picked from commit d70c7b5) * name validation fix, page navigate fix (#14724) - fine-tune name validation and warning display - also fixes issue when navigating away from the publish page and setting up the datacontext of the PackageManagerPublishControl (cherry picked from commit 57f5883) * reset selected known hosts (#14722) - now resets selected known hosts between publish package usages/resets (cherry picked from commit f5fddc3) --------- Co-authored-by: Deyan Nenov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A small PR reinstating the Description field check. The check was removed from the UI but it remains as part of the Greg request API. The process of submitting a package online would fail without a description, which would contradict the UI form, so bringing back the check.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@avidit
@reddyashish
FYIs
@QilongTang