DYN-6397 Fix crash when parent node is deleted while node autocomplete menu is displayed by zeusongit · Pull Request #14715 · DynamoDS/Dynamo

zeusongit · 2023-12-07T22:08:42Z

Purpose

https://jira.autodesk.com/browse/DYN-6397

When a user deletes a node that has the node autocomplete menu open, it leaves the menu dissociated with the node and when a user clicks on any item on the menu, Dynamo crashed.

This PR fixes this case by closing the associated node autocomplete menu when the parent node is deleted.
On delete key press event any open node autocomplete menu will be closed.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

Fix crash when parent node is deleted while node autocomplete menu is displayed

Reviewers

@DynamoDS/dynamo

This reverts commit a588d14.

github-actions · 2023-12-07T22:30:29Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-07T22:30:29Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

github-actions · 2023-12-08T06:55:01Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-08T19:57:22Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-08T20:01:09Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

zeusongit · 2023-12-08T20:27:45Z

Added a test, and reviewed the comments

github-actions · 2023-12-08T20:48:32Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-08T20:48:59Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

QilongTang · 2023-12-11T06:19:00Z

Are there any regressions?

zeusongit · 2023-12-11T21:44:06Z

Are there any regressions?

I see 18 test failed, but seems un-related, and passes locally.

github-actions · 2023-12-12T06:50:02Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-12T06:50:45Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

QilongTang · 2023-12-12T12:46:32Z

Maybe try the self serve on master-15? Even after I update your branch with master, there are still a bunch failures.

…ac-fix

… nodeac-fix

github-actions · 2023-12-12T17:03:50Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

github-actions · 2023-12-12T17:08:17Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

zeusongit · 2023-12-12T22:14:38Z

Maybe try the self serve on master-15? Even after I update your branch with master, there are still a bunch failures.

Tried master-15 , but each run gets me a different result, not sure what the problem is, I will wait for the ongoing issue with async test runs to resolve.

pinzart90 · 2023-12-13T13:59:34Z

src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml.cs

        internal void CloseAutoCompletion()
        {
            OnRequestShowNodeAutoCompleteSearch(ShowHideFlags.Hide);
+            ViewModel.OnNodeAutoCompleteWindowClosed();


Looks like the ViewModel could be null here
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/12457/testReport/Dynamo.Tests/WorkspaceOpeningTests/ClearingWorkspaceResetsPositionAndZoom/

github-actions · 2023-12-13T15:29:50Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-13T15:33:35Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

zeusongit · 2023-12-13T17:11:07Z

No regression, all checks passed, merging.

…e menu is displayed (DynamoDS#14715) * Fix PostDiff job * fix * Revert different commit This reverts commit a588d14. * comments * add unsub * add test * Update NodeAutoCompleteSearchControl.xaml.cs --------- Co-authored-by: Aaron (Qilong) <[email protected]>

zeusongit added 25 commits August 11, 2023 10:14

Fix PostDiff job

56ba101

Merge branch 'master' of https://github.com/zeusongit/Dynamo

dc250de

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

1fecd29

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

90a6c41

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

64c202b

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

d6ac751

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

255feeb

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

4e55f7f

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

1886669

Merge branch 'master' of https://github.com/zeusongit/Dynamo

8ac6b74

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

41c461c

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

f9cf237

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

a0adaef

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

2ab3d49

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

558df01

Merge branch 'master' of https://github.com/zeusongit/Dynamo

efdb82b

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

9b712f2

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

7c2dc1e

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

83bcb52

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

30b861d

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

71d23c2

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

cd1c4f9

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

0cae237

fix

a588d14

Revert different commit

45eddb0

This reverts commit a588d14.

zeusongit requested review from QilongTang and reddyashish December 7, 2023 22:08

QilongTang added this to the 3.0 milestone Dec 8, 2023

avidit changed the title ~~Fix crash when parent node is deleted while node autocomplete menu is displayed~~ DYN-6397 Fix crash when parent node is deleted while node autocomplete menu is displayed Dec 8, 2023

add unsub

fba8e45

add test

f7c3fcd

zeusongit requested a review from QilongTang December 8, 2023 20:27

QilongTang approved these changes Dec 9, 2023

View reviewed changes

Merge branch 'master' into nodeac-fix

69afd3e

zeusongit added 2 commits December 12, 2023 11:41

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into node…

35d997b

…ac-fix

Merge branch 'nodeac-fix' of https://github.com/zeusongit/Dynamo into…

4636c6d

… nodeac-fix

pinzart90 reviewed Dec 13, 2023

View reviewed changes

Update NodeAutoCompleteSearchControl.xaml.cs

e1dbf02

zeusongit merged commit bcdeccb into DynamoDS:master Dec 13, 2023

zeusongit mentioned this pull request Dec 13, 2023

Cherrypick Heartbeat Log and NodeAutocomplete crash fix #14756

Merged

9 tasks

Conversation

zeusongit commented Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

Uh oh!

github-actions bot commented Dec 7, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 7, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Uh oh!

zeusongit commented Dec 8, 2023

Uh oh!

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Uh oh!

QilongTang commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeusongit commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 12, 2023

UI Smoke Tests

Uh oh!

QilongTang commented Dec 12, 2023

Uh oh!

github-actions bot commented Dec 12, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 12, 2023

UI Smoke Tests

Uh oh!

zeusongit commented Dec 12, 2023

Uh oh!

pinzart90 Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 13, 2023

UI Smoke Tests

Uh oh!

github-actions bot commented Dec 13, 2023

UI Smoke Tests

Uh oh!

zeusongit commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeusongit commented Dec 7, 2023 •

edited

Loading

QilongTang commented Dec 11, 2023 •

edited

Loading

zeusongit commented Dec 11, 2023 •

edited

Loading