DYN-6507: crash when uploading package#14690
Merged
reddyashish merged 5 commits intoDynamoDS:masterfrom Dec 7, 2023
Merged
Conversation
- attempt to fix a crash when uploading a package and clearing the uploadhandle on success
dnenov
changed the title
Collaborator
|
@dnenov 1 failure here: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1329/. No test runner crash now |
Collaborator
|
1 failure |
- disabled CancelCommandClearsAllData test as the command it is supposed to be testing currently is restricted under testing environment as it crashes master-15 (sequentially running of tests) because of thread affinity issue
Collaborator
Author
|
I disabled CancelCommandClearsAllData test as the command it is supposed to be testing, is currently restricted under testing environment. It crashes master-15 (sequentially running of tests) because of thread affinity issue. So this test does not make sense at the moment. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
reddyashish
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Revert change that was introduced to try and fix failing tests before. The change was a
BeingInvokewrap around a clean up of a property which was used inside async code. The use of theBeginInvokewas causing a crash in production code in Dynamo.This jira issue picks it up https://jira.autodesk.com/browse/DYN-6507?filter=-1
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@avidit
@mjkkirschner