Pm publishpackage cherrypick mypackage#14645
Merged
reddyashish merged 7 commits intoDynamoDS:masterfrom Nov 29, 2023
Merged
Conversation
- picked up all resource changes
…-cherrypick-resources
- this cherry-pick contains all main changes minus resources and tests. - will need to merge resources to work correctly - if this breaks the test run, we will need to further split it up, or introduce the changes one by one somehow
…package-cherrypick-mypackage
- added a null check
- this was done to try and fix a failing test but it should not be needed
- trying to prevent null exceptions in case resources have been cleared before dispose event has been called
This was referenced Nov 29, 2023
Collaborator
|
self-serve CI has run all the tests https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1292/. without any test runner crash. The 7 assertion failures(related to packages count) seen here are related to that machine as the master branch also has the same failures. The pull req validation has also passed. @dnenov has a different PR for covering the tests on this feature. |
reddyashish
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The second part of cherry-picks from #14631. This PR requires the resources published with this PR #14644.
The current PR contains all of the main changes in relation to the My Packages functionality. If there are any issues with this branch, we may have to split it further down to identify the issue.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@QilongTang
FYIs