DYN-6339, DYN-6322 - honours filters during search#14591
Merged
reddyashish merged 4 commits intoDynamoDS:masterfrom Nov 14, 2023
Merged
DYN-6339, DYN-6322 - honours filters during search#14591reddyashish merged 4 commits intoDynamoDS:masterfrom
reddyashish merged 4 commits intoDynamoDS:masterfrom
Conversation
- now honors active filters while searching
reddyashish
reviewed
Nov 10, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
reddyashish
approved these changes
Nov 10, 2023
Collaborator
reddyashish
left a comment
There was a problem hiding this comment.
LGTM with a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes where filters would not be applied during the search when using the search packages in the Package Manager. Now the filters will be applied post-search and the results will be correctly filtered.
Addresses the following jira issues:
Workflow
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@avidit
@Jingyi-Wen
@reddyashish
FYIs
@Amoursol