DYN-6365 Promote Gate node from GD Extension to Dynamo Core.#14528
Merged
saintentropy merged 8 commits intoDynamoDS:masterfrom Nov 13, 2023
Merged
DYN-6365 Promote Gate node from GD Extension to Dynamo Core.#14528saintentropy merged 8 commits intoDynamoDS:masterfrom
saintentropy merged 8 commits intoDynamoDS:masterfrom
Conversation
twastvedt
approved these changes
Oct 30, 2023
Contributor
twastvedt
left a comment
twastvedt
left a comment
There was a problem hiding this comment.
I assume this is just copied from the extension - any changes from that code that require more careful inspection?
Also, can we consider an icon change? The icon looks to me like a circuit switch symbol, where "open" means no electricity flows through. Instead our terminology treats this node more like a fence gate: "open" means the cows flow through. Perhaps we could change the icon to something that reflects this? The description is, admittedly, clear, but I think many people's immediate instinct might be "incorrect" based on the icon.
QilongTang
approved these changes
Oct 30, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of the PR is to migrate the Gate Node from the GD Extension to Dynamo Core.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Dynamo now has the Gate node in the Out of the Box Library. The gate node allows you control the execution in sections of you graph. An open Gate passes data through unchanged. A closed Gate sends no data downstream.
Reviewers
@LongNguyenP @twastvedt
FYIs
@jnealb