DYN-6355 Warning messages content truncated when message includes link#14514
Merged
saintentropy merged 5 commits intoDynamoDS:masterfrom Nov 16, 2023
Merged
DYN-6355 Warning messages content truncated when message includes link#14514saintentropy merged 5 commits intoDynamoDS:masterfrom
saintentropy merged 5 commits intoDynamoDS:masterfrom
Conversation
Member
|
LGTM - would be nice to have a test that asserts your example returns the text you expect or is over a certain length or something. |
Contributor
Author
|
@mjkkirschner agree on the test. I will add it as soon as the Remember node merges :-) |
mjkkirschner
approved these changes
Nov 15, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
For the rare case of Node Warnings that are a combination of multiple runtime and build warnings the content can be truncated when the message text is processed to remove help link text.
This change maintains the contents of the full message and format the view for clarity.
Before (Truncated message):

After (Full message):

Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Dynamo no longer truncates the rare case of Node Warnings that are a combination of multiple runtime and build warnings.
Reviewers
@mjkkirschner
FYIs
@LongNguyenP @QilongTang