Skip to content

package zoom out state#14507

Merged
QilongTang merged 3 commits intoDynamoDS:masterfrom
dnenov:custompkg-zoomedout-states
Oct 24, 2023
Merged

package zoom out state#14507
QilongTang merged 3 commits intoDynamoDS:masterfrom
dnenov:custompkg-zoomedout-states

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Oct 22, 2023 •
edited
Loading

Purpose

Adjusting zoomed-out states behavior to favor Package over Preview state:

zoomed-in

image

zoomed-out

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • changed order of zoom out states to favor package over preview off
  • priorities are Error > Warning > Info ; Frozen > Package > Preview > None

Reviewers

@Amoursol
@reddyashish

FYIs

dnenov and others added 2 commits October 22, 2023 12:04
@dnenov
package zoom out state
ae5cb89 
- changed order of zoom out states to favor package over preview off
- priorities are Error > Warning > Info ; Frozen > Package > Preview > None
@QilongTang
Merge branch 'master' into custompkg-zoomedout-states
5863322
@QilongTang QilongTang added this to the 3.0 milestone Oct 23, 2023
QilongTang
QilongTang reviewed Oct 23, 2023
View reviewed changes
src/DynamoCoreWpf/ViewModels/Core/NodeViewModel.cs
using System.Text.RegularExpressions;
using System.Windows;
using System.Windows.Controls.Primitives;
using System.Windows.Media;
Copy link
Contributor

@QilongTang QilongTang Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards#usings and revert such change

QilongTang
QilongTang reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@QilongTang QilongTang merged commit 892253e into DynamoDS:master Oct 24, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Oct 24, 2023 •
edited
Loading

@dnenov Oops, I accidentally merged this one, I will cover the using order in my other PR so don't worry about it. Also, can you re-attach the screenshot for the zoomed-out state, the resolution is not good enough.

@dnenov
Copy link
Collaborator Author

dnenov commented Oct 25, 2023

@dnenov Oops, I accidentally merged this one, I will cover the using order in my other PR so don't worry about it. Also, can you re-attach the screenshot for the zoomed-out state, the resolution is not good enough.

Updated the image as needed, @QilongTang! I also made the change in VS so the order of the namespaces should be good from now on.

@dnenov dnenov mentioned this pull request Oct 9, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dnenov @QilongTang