DYN-6186: Add option to provide tooltips to message boxes#14500
Merged
aparajit-pratap merged 16 commits intoDynamoDS:masterfrom Oct 20, 2023
Merged
DYN-6186: Add option to provide tooltips to message boxes#14500aparajit-pratap merged 16 commits intoDynamoDS:masterfrom
aparajit-pratap merged 16 commits intoDynamoDS:masterfrom
Conversation
aparajit-pratap
changed the title
pinzart90
reviewed
Oct 19, 2023
mjkkirschner
approved these changes
Oct 19, 2023
Member
mjkkirschner
left a comment
mjkkirschner
left a comment
There was a problem hiding this comment.
just small comments but nothing that blocks this from being merged.
Contributor
|
Oops, I'm late to the party. I was going to suggest a visibility converter binded to the tooltip so if the tooltip is empty we do not show the question mark.. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added a way to add tooltips to DynamoMessageBox.
Added one for ElementBinding Warning message box that appears on SaveAs in certain scenarios.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@Jingyi-Wen