DYN-5961 Set Dynamo locale based on setting or host#14486
Merged
QilongTang merged 3 commits intomasterfrom Oct 18, 2023
Merged
Conversation
QilongTang
commented
Oct 16, 2023
| public static void SetUICulture(string locale) | ||
| { | ||
| Thread.CurrentThread.CurrentUICulture = new CultureInfo(locale == "Default" ? "en-US" : locale); | ||
| Thread.CurrentThread.CurrentCulture = new CultureInfo(locale == "Default" ? "en-US" : locale); |
Contributor
Author
There was a problem hiding this comment.
These code were added in Dynamo 2.18 but removed in Dynamo 2.19. So this would mean adding these code back but conditionally (in-process integration)
Contributor
Author
|
Only regression fixed by updating baseline test |
reddyashish
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce Default option in Language switch, which sets Dynamo locale based on setting or host, pending some testing
Screenshot:

Behavior:
Defaultwill be the default option for fresh Dynamo launchDefaultoption in DynamoSandbox meansen-USDefaultoption in Dynamo in-process integration means following the host locale setting, based on the fact both DynamoRevit and DynamoC3D modifiesHostAnalyticsInfoobjectDefaultoption in Dynamo out-of-process integration meansen-USor following host locale setting, depending on if integrator modifiesHostAnalyticsInfoobjectDeclarations
Check these if you believe they are true
*.resxfilesRelease Notes
Set Dynamo locale based on setting or host
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of