⚠️ [run-bin-diff] - Files Added/Deleted::2 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::2 file(s) have been deleted!

I believe we need a few more changes in D4R repo - that is we need some journal key there that will passed on as skip lucene in the startup config here. That is so that we can stop the indexing from DynamoPlayer context.
Or actually we can turn off the searching directly in D4R code which will apply to Player as well without the need to add extra journal keys there. It is off by default if we want to go this way.
GD Should not be affected but just in case if we want to stop this in CLI mode as well we need to have a new CLI startup parameter as well.

But it looks like we can hold off with this fix in the near future and deal with the performance.

@BogdanZavu @twastvedt With the recent performance improvement, do you think if we still need this change?

The numbers you posted look really good. I'd say no, at least for now.

I think we can hold off on this change for now.
But perhaps we can come back to it later. Maybe we don't even need a flag, is there any reason to do the indexing in headless/clis modes ?

@BogdanZavu @twastvedt Thank you for confirmation. But I think indexing is not strictly required especially in service mode.

Yep, definitely agree that ideally we'd be able to turn off indexing. Maybe always in both CLI and service modes? I agree with Bogdan that we don't need a flag, just don't have it on where it's not needed.