Merged
Conversation
Contributor
Author
|
Marking this ready just so PR checks could run |
Contributor
Author
|
@avidit Branch build available at storebox\DynamoCore\LuceneSearchIMP\px64\LuceneSearchIMP_3.0.0.6295 for testing |
| internal Document InitializeIndexDocumentForNodes() | ||
| { | ||
| if (DynamoModel.IsTestMode && currentStorageType == LuceneStorage.FILE_SYSTEM) return null; | ||
| if (DynamoModel.IsTestMode && startConfig.StorageType == LuceneStorage.FILE_SYSTEM) return null; |
Member
There was a problem hiding this comment.
should this log an error or something to the console?
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
reddyashish
reviewed
Sep 28, 2023
QilongTang
commented
Sep 29, 2023
9 tasks
QilongTang
changed the title
QilongTang
force-pushed
the
LuceneSearchIMP
branch
from
e12b271 to
c38e028
Compare
Contributor
Author
|
@reddyashish Thanks for the review! Merging now |
QilongTang
added a commit
that referenced
this pull request
Mar 4, 2024
* improvements * Simply initialization logic * Skip indexing as part of DynamoModel if the index files already exist * Remove DynamoModel reference and use singleton * clean up * improvements and package manager search * Use single constructor and other code clean up * Update... * Update * Dispose all Lucene objects in the correct order * Adding DynamoModel back to test regressions * Null check * Update * IndexWriter dispose sequence only for non-RAM mode
9 tasks
QilongTang
added a commit
that referenced
this pull request
Mar 5, 2024
* DYN-6038 Lucene search IMP (#14428) * improvements * Simply initialization logic * Skip indexing as part of DynamoModel if the index files already exist * Remove DynamoModel reference and use singleton * clean up * improvements and package manager search * Use single constructor and other code clean up * Update... * Update * Dispose all Lucene objects in the correct order * Adding DynamoModel back to test regressions * Null check * Update * IndexWriter dispose sequence only for non-RAM mode * Update * Lucene index amend improvements (#14513) * Use index writer to amend index after Dynamo Launch * Update sorting * Update * Update * Update * Make sure package loading end will already release index lock * Update Comments * Clean Up * Code clean up * clean up * Code Clean Up * regressions * revert code clean up because it affects running tests in parallel * update * update * Update AssemblySharedInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improvements to Lucene search, a legacy branch build available at storebox\DynamoCore\LuceneSearchIMP\px64\LuceneSearchIMP_3.0.0.6295
Here are the improvements included:
AddNodeTypeToSearchIndexand add it to utility classSkip writing index files if they exist, read index files when available in the same caseDeclarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of