Removing legacy search in Dynamo#14413
Merged
reddyashish merged 7 commits intoDynamoDS:masterfrom Sep 16, 2023
Merged
Conversation
reddyashish
commented
Sep 14, 2023
reddyashish
commented
Sep 14, 2023
QilongTang
reviewed
Sep 15, 2023
QilongTang
reviewed
Sep 15, 2023
Collaborator
Author
|
Building fine now, needed to change one of the recently added lucene test. |
Contributor
Cool, waiting for PR checks |
Contributor
Collaborator
Author
|
Fixed the test now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is to remove the legacy search in Dynamo and Lucene search will be used in all components.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Removing legacy search in Dynamo
Reviewers
@QilongTang @RobertGlobant20
FYIs
@DynamoDS/dynamo