Add DynamoPythonTests to sln#14407
Merged
mjkkirschner merged 11 commits intoDynamoDS:masterfrom Sep 19, 2023
Merged
Conversation
…ynamoDS#14344) * fixing mem leaks in progress * fix test and remove todo
* cherry pick analytics issue (DynamoDS#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (DynamoDS#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (DynamoDS#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
|
|
| Assert.IsTrue(completionList.Intersect(new[] { "Hashtable", "Queue", "Stack" }).Count() == 3); | ||
| // Serial tests load an extra type (System.Collections.Immutable) in the Python engine | ||
| Assert.IsTrue(completionData.Length >= 29 && completionData.Length <= 30); | ||
| Assert.IsTrue(completionData.Length == 31); |
Member
Author
There was a problem hiding this comment.
there are more types which are imported in net6 vs net48 - I got rid of the zany logic because AFAIK the same number of types seem to be imported when running one or multiple tests.
aparajit-pratap
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add DynamoPythonTests to sln - note that the tests are not yet part of the test run - we need to merge this first:
https://git.autodesk.com/Dynamo/DynamoSelfServe/pull/113
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers