2.19.1 disable network traffic by mjkkirschner · Pull Request #14393 · DynamoDS/Dynamo

mjkkirschner · 2023-09-08T13:57:55Z

This pulls in some changes from @pinzart90's changes for 2.17.4 and tries to adapt them to use the DisableAnalytics flag as a stand in DisableNetworkActivity flag until we have that.

Additionally, it disables the notification center requests if DisableAnalytics is true.

I believe it is safe to merge to master, unlike the original changes.

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

This reverts commit 6f9761d.

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]>

github-actions · 2023-09-08T14:10:06Z

⚠️ [run-bin-diff] - Files Added/Deleted::75 new file(s) have been added and 153 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::15 new file(s) have been added and 29 file(s) have been deleted!
(Updated: 2023-09-11-15:15:34)

src/DynamoApplications/StartupUtils.cs

QilongTang · 2023-09-11T14:49:06Z

@mjkkirschner All changes looks good, this is no longer WIP right?

mjkkirschner · 2023-09-11T14:55:27Z

@QilongTang let me make a few last updates to this!

mjkkirschner · 2023-09-11T15:03:37Z

@QilongTang @sm6srw PTAL - I added some TODO comments and also disabled the notifications center if the DisableAnalytics static props was set true.

I think this should be safe to merge to master as well so we can stop doing these one off builds in the future.

sm6srw

LGTM!

QilongTang · 2023-09-11T15:19:44Z

@QilongTang @sm6srw PTAL - I added some TODO comments and also disabled the notifications center if the DisableAnalytics static props was set true.

I think this should be safe to merge to master as well so we can stop doing these one off builds in the future.

Thanks, nicely done

mjkkirschner · 2023-09-11T15:26:41Z

@QilongTang I was hoping we'd wait for the tests to pass 😬 - I will keep an eye on them.

QilongTang · 2023-09-11T15:29:01Z

@mjkkirschner The previous job does have tests passed and given we have no tests for notification center, I merged. I will have another PR to update release version etc

* cherry pick analytics issue (DynamoDS#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (DynamoDS#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (DynamoDS#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> * add python tests * move project * revert --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

pinzart90 and others added 5 commits September 8, 2023 09:52

cherry pick analytics issue (#13328)

f799885

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

Revert "cherry pick analytics issue (#13328)"

97fe2f8

This reverts commit 6f9761d.

cherry pick analytics issue (#13328) (#14085)

09212a0

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

Disable net traffic (#14083)

d249dba

* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]>

Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

425b404

* Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]>

sm6srw reviewed Sep 8, 2023

View reviewed changes

src/DynamoApplications/StartupUtils.cs Outdated Show resolved Hide resolved

mjkkirschner added 2 commits September 8, 2023 10:18

changes

b5b00f8

remove comment

5099ade

QilongTang changed the title ~~219disablenet WIP~~ 219 disable network traffic WIP Sep 11, 2023

QilongTang changed the base branch from RC2.19.0_master to RC2.19.1_master September 11, 2023 14:41

QilongTang added this to the 2.19.1 milestone Sep 11, 2023

QilongTang approved these changes Sep 11, 2023

View reviewed changes

QilongTang changed the title ~~219 disable network traffic WIP~~ 2.19.1 disable network traffic WIP Sep 11, 2023

comments and disable notifications

b7536f8

sm6srw approved these changes Sep 11, 2023

View reviewed changes

QilongTang merged commit bb0f4b2 into RC2.19.1_master Sep 11, 2023

QilongTang deleted the 219disablenet branch September 11, 2023 15:25

QilongTang changed the title ~~2.19.1 disable network traffic WIP~~ 2.19.1 disable network traffic Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.19.1 disable network traffic#14393

2.19.1 disable network traffic#14393
QilongTang merged 8 commits intoRC2.19.1_masterfrom
219disablenet

mjkkirschner commented Sep 8, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Sep 8, 2023 •

edited

Loading

Uh oh!

Uh oh!

QilongTang commented Sep 11, 2023

Uh oh!

mjkkirschner commented Sep 11, 2023

Uh oh!

mjkkirschner commented Sep 11, 2023 •

edited

Loading

Uh oh!

sm6srw left a comment

Uh oh!

QilongTang commented Sep 11, 2023

Uh oh!

mjkkirschner commented Sep 11, 2023 •

edited

Loading

Uh oh!

QilongTang commented Sep 11, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mjkkirschner commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

QilongTang commented Sep 11, 2023

Uh oh!

mjkkirschner commented Sep 11, 2023

Uh oh!

mjkkirschner commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sm6srw left a comment

Choose a reason for hiding this comment

Uh oh!

QilongTang commented Sep 11, 2023

Uh oh!

mjkkirschner commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QilongTang commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mjkkirschner commented Sep 8, 2023 •

edited

Loading

github-actions bot commented Sep 8, 2023 •

edited

Loading

mjkkirschner commented Sep 11, 2023 •

edited

Loading

mjkkirschner commented Sep 11, 2023 •

edited

Loading

QilongTang commented Sep 11, 2023 •

edited

Loading