Pm search for packages - votes by dnenov · Pull Request #14390 · DynamoDS/Dynamo

dnenov · 2023-09-07T16:27:21Z

Purpose

Greg route working, now checks if user has voted for a package to prevent further voting. Current behavior is as follows:

users can vote for a package that has been installed
users can vote if they have signed in
users can vote if they haven't already voted for that package
if the above criteria is met, the user will be allowed to vote for a package through the details panel
the user will see visual indication for all voted packages

~~!!! Greg updated! The new request GetUserVotes to add the user/votes route that was introduced with this PR is still not showing on the Dynamo side.~~

This is a cherry-pick with package manager changes around the detailed package extension, and specifically the votes behavior. Alongside the visual updates, the PR changes the following - users will be able to vote for a package if they have it installed. Downloading is still disabled.

UI Changes

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

adding changes connected to the 'votes' behavior
voting for packages functionality reinstated
checking for user votes on loading
if the user has already voted for a package prevents from voting again
ui updates

Reviewers

@zeusongit
@sm6srw

FYIs

@QilongTang

- adding changes connected to the 'votes' behavior

- still not showing the new 'GetUserVotes' request that was added with this PR DynamoDS/PackageManagerClient#84

zeusongit · 2023-09-07T16:36:36Z

Sorry, I reviewed one commit(was routed through outlook) rather than the PR, will wait for the PR to be ready for review.

QilongTang · 2023-09-07T16:37:33Z

hi @zeusongit, Deyan mentioned with the newer version of Greg, the new route does not exist still so this PR does not build

zeusongit · 2023-09-07T17:01:29Z

hi @zeusongit, Deyan mentioned with the newer version of Greg, the new route does not exist still so this PR does not build

Hi @QilongTang , I tried it locally, i updated the greg package to 6084, and it is building for me successfully locally, one thing that I noticed is that maybe greg is not updated in all the locations where it is used, so do a complete update maybe?

…ges-votes

reddyashish · 2023-09-19T14:10:35Z

@dnenov Is this ready for review or any changes coming in?

…ges-votes

- voting for packages functionality reinstated - checking for user votes on loading - if the user has already voted for a package prevents from voting again - ui updates

- now correctly updates the SeachElement item inside the PackageManagerPackagesControl 'votes' icon when user has voted for a package - now allows to vote for a package right after a package has been installed

…ges-votes

dnenov · 2023-10-22T10:27:34Z

@dnenov Is this ready for review or any changes coming in?

Hey @reddyashish ! This one is definitely ready for review, it must have fallen under the cracks. My bad!

- removed duplicate package references

reddyashish · 2023-10-24T12:42:35Z

test/Libraries/PackageManagerTests/PackageManagerClientTests.cs

            Assert.IsFalse(res);
        }

+        //[Test]


Uncomment this test? would be nice to test this. Is the mock test failing for any reason?

reddyashish · 2023-10-24T12:42:43Z

src/DynamoPackages/PackageManagerClient.cs

+                return pkgResponse.content;
+            }, null);
+
+            return votes.has_upvoted;


the local variable votes will be null when the function fails. Check for null before returning its property.

src/DynamoPackages/DynamoPackages.csproj

src/DynamoCoreWpf/DynamoCoreWpf.csproj

src/DynamoCore/DynamoCore.csproj

src/PackageDetailsViewExtension/PackageDetailsViewModel.cs

reddyashish · 2023-10-24T12:47:59Z

Some comments @dnenov. Also double check the additional references that are added. You would need to pull in the latest master again to resolve the conflicts.

…ges-votes

- reconciled meshed up references - comments

- last reference?

reddyashish · 2023-10-25T15:52:16Z

src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs

 [assembly: AssemblyCompany("Autodesk, Inc")]
 [assembly: AssemblyProduct("Dynamo")]
-[assembly: AssemblyCopyright("Copyright © Autodesk, Inc 2023")]
+[assembly: AssemblyCopyright("Copyright � Autodesk, Inc 2023")]


This file shouldn't be added, that is why the self-serve is failing.

reddyashish · 2023-10-25T17:11:48Z

3 failing tests on this PR. Can you take a look.

dnenov · 2023-10-25T18:09:03Z

3 failing tests on this PR. Can you take a look.

Sure thing, and I will sort out the Assemblies entry.

- revert changes made by mistake

…ges-votes

dnenov added 2 commits September 7, 2023 17:16

votes cherry pick

4913db8

- adding changes connected to the 'votes' behavior

Greg update

9cc4769

- still not showing the new 'GetUserVotes' request that was added with this PR DynamoDS/PackageManagerClient#84

zeusongit approved these changes Sep 7, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…

fc2437a

…ges-votes

dnenov added 5 commits September 25, 2023 17:18

Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…

42c3ee4

…ges-votes

Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…

5700541

…ges-votes

votes cherry pick

274f4a8

- voting for packages functionality reinstated - checking for user votes on loading - if the user has already voted for a package prevents from voting again - ui updates

minor fixes

0b13c6e

- now correctly updates the SeachElement item inside the PackageManagerPackagesControl 'votes' icon when user has voted for a package - now allows to vote for a package right after a package has been installed

Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…

61acda0

…ges-votes

dnenov marked this pull request as ready for review October 22, 2023 10:26

Greg - Duplicate 'PackageReference' items found

0d34642

- removed duplicate package references

reddyashish reviewed Oct 24, 2023

View reviewed changes

src/DynamoPackages/DynamoPackages.csproj Outdated Show resolved Hide resolved

reddyashish reviewed Oct 24, 2023

View reviewed changes

src/DynamoCoreWpf/DynamoCoreWpf.csproj Outdated Show resolved Hide resolved

reddyashish reviewed Oct 24, 2023

View reviewed changes

src/DynamoCore/DynamoCore.csproj Outdated Show resolved Hide resolved

reddyashish reviewed Oct 24, 2023

View reviewed changes

src/PackageDetailsViewExtension/PackageDetailsViewModel.cs Outdated Show resolved Hide resolved

dnenov added 3 commits October 25, 2023 08:45

Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…

4b0382d

…ges-votes

references reconciliation

25d73b5

- reconciled meshed up references - comments

reference fix

dffb0cf

- last reference?

reddyashish reviewed Oct 25, 2023

View reviewed changes

revert assemblyinfo changes

e70eaaf

- revert changes made by mistake

dnenov added 2 commits October 26, 2023 10:56

failing tests fix

656a1df

Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…

2f0e46c

…ges-votes

reddyashish approved these changes Oct 26, 2023

View reviewed changes

QilongTang added this to the 3.0 milestone Oct 26, 2023

reddyashish merged commit 8eee844 into DynamoDS:master Oct 27, 2023

Conversation

dnenov commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

UI Changes

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

zeusongit commented Sep 7, 2023

Uh oh!

QilongTang commented Sep 7, 2023

Uh oh!

zeusongit commented Sep 7, 2023

Uh oh!

reddyashish commented Sep 19, 2023

Uh oh!

dnenov commented Oct 22, 2023

Uh oh!

reddyashish Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

reddyashish Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reddyashish commented Oct 24, 2023

Uh oh!

reddyashish Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

reddyashish commented Oct 25, 2023

Uh oh!

dnenov commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dnenov commented Sep 7, 2023 •

edited

Loading