AGD-3085 : fix cast crash#14351
Merged
BogdanZavu merged 1 commit intoDynamoDS:masterfrom Aug 31, 2023
Merged
Conversation
QilongTang
approved these changes
Aug 30, 2023
Contributor
|
Nice catch, can the crash case be written into a unit test? |
Contributor
Author
Contributor
Author
|
@QilongTang I think this is more of an integration test ; this utility is not covered and it's usage is related to a more complex workflow which involves rendering - but it will be tested as part of player integration tests which are in the works. |
Contributor
Thank you! Make sense |
BogdanZavu
added a commit
to BogdanZavu/Dynamo
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Bogdan Zavu <[email protected]>
BogdanZavu
added a commit
to BogdanZavu/Dynamo
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Bogdan Zavu <[email protected]>
QilongTang
pushed a commit
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Bogdan Zavu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a crash when the renderPackage is not a HelixRenderPackage
Declarations
Check these if you believe they are true
*.resxfiles