Cherry-Pick-DYN-6073 civil3 d packages tour crashing (#14338)#14343
Merged
QilongTang merged 2 commits intoDynamoDS:RC2.19.0_masterfrom Aug 29, 2023
RobertGlobant20:RC2.19.0_master
Merged
Cherry-Pick-DYN-6073 civil3 d packages tour crashing (#14338)#14343QilongTang merged 2 commits intoDynamoDS:RC2.19.0_masterfrom RobertGlobant20:RC2.19.0_master
QilongTang merged 2 commits intoDynamoDS:RC2.19.0_masterfrom
RobertGlobant20:RC2.19.0_master
Conversation
* DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.
Contributor
Author
|
@QilongTang When I did the cherry-pick I noticed this changes (but were not done by me), do you know something about it?. |
Contributor
Git cherry-pick is not guaranteed to always be accurate, let's just remove the changes unintended |
When creating the cherry-pick for RC2.19_master branch I noticed some changes that I didn't do, so I'm reverting those changes.
QilongTang
approved these changes
Aug 29, 2023
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry-Pick-DYN-6073 civil3 d packages tour crashing #14338
This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window.
This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Cherry-Pick-DYN-6073 civil3 d packages tour crashing #14338
Reviewers
@QilongTang
FYIs