Pm search for packages - filters by dnenov · Pull Request #14322 · DynamoDS/Dynamo

dnenov · 2023-08-25T19:05:30Z

Purpose

Continuation of the work done on the Package Manager. This PR focuses on the implementation of new Filters in the first tab of the PM - the Search for Packages tab.

3 new subcategories of filters created:

Host (existing filters)
Status (New, Updated, Deprecated)
Package Dependency (with and without dependencies)

Filter tag bubbles added to the UI with the expected functionality.

UI Changes

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

new context menu items added to the Filters menu
~~Sorting changed - default priority now to 'votes~~ reverted back to last update
FilterTag bubble custom control created
clear all button clears all currently applied filters
no selected package when opening the package manager for the first time
standardized UI styles
uses FilterEntity between host and non-host filters (reusing the logic of the existing host filter VM as much as possible)
the filter context menu now stays open while the user interacts with it allowing multiple filters to be applied consecutively
has dependency and has no dependency filters toggle each other out, if positive (they are mutually exclusive)

Reviewers

@QilongTang
@reddyashish

FYIs

@Amoursol

- moving 'SearchForPackages' PR into smaller PRs - main chunk of work on the PackageManagerSearchControl -- context menu -- filter tags

- added all filters to the GetAllPackages routine

- removed the `active` filter - introduced `new` and `updated` as status filters

- added 'clear all' to resources

- no selected package when opening the package manager for the first time

- correctly assigned the `clear all` button text

- replaced boolean propertie representing the new filters with FilterEntity

- added tests for the new filters

- standardized ui element styles

- the user will be able to select multiple filters without the context menu closing

src/DynamoCoreWpf/Properties/Resources.resx

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs

- the two dependency filters (package 'has decency' and 'has no dependency') cannot be both in positive states - adjusted tests to take that change into account

- reverted default sorting back to `LastUpdate`

src/DynamoPackages/PackageManagerSearchElement.cs

src/DynamoCoreWpf/Views/PackageManager/Controls/FilterTagControl.xaml.cs

QilongTang

Some comments then LGTM, also some merge conflicts because the version PR merged today

- added tooltips for all new filters, - updated old filters, - changed styling

- added comments for the public properties of the FilterTagControl

src/DynamoCoreWpf/Views/PackageManager/Controls/FilterTagControl.xaml.cs

reddyashish · 2023-09-13T16:44:03Z

test/DynamoCoreWpfTests/PackageManager/PackageManagerSearchElementViewModelTests.cs

+        /// `Has Dependency` and `Has No Dependency` filters are mutually exclusive
+        /// </summary>
+        [Test]
+        public void PackageSearchDialogSearchTestDependencyFilters()


@dnenov Thank you for covering these tests.

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs

- replaced hard-coded string value with nameof property

QilongTang · 2023-09-13T17:31:25Z

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs

+        //private bool showDeprecated;
+        //private bool showDependencies;
+        //private bool showNoDependencies;
+        //private bool isAnyFilterOn;


Can we remove this commented code?

Yes, absolutely, sorry for the mess.

QilongTang

LGTM with one minor comment left. Also @dnenov can you remind me if we covered the fix that first time launching Dynamo PM the first package entry is always highlighted somewhere?

dnenov · 2023-09-13T20:03:33Z

LGTM with one minor comment left. Also @dnenov can you remind me if we covered the fix that first time launching Dynamo PM the first package entry is always highlighted somewhere?

Yup, we did it in this commit part of this PR. The initial index is set to -1.

dnenov added 6 commits August 25, 2023 16:13

Initial PR transition

8a2d73f

- moving 'SearchForPackages' PR into smaller PRs - main chunk of work on the PackageManagerSearchControl -- context menu -- filter tags

filter search results

7aa4170

- added all filters to the GetAllPackages routine

new and updated status filters, removed active

8e958c7

- removed the `active` filter - introduced `new` and `updated` as status filters

clear all button to resources

b986c39

- added 'clear all' to resources

remove initially selected package

8320355

- no selected package when opening the package manager for the first time

clear filters button resource assigned

f427e35

- correctly assigned the `clear all` button text

QilongTang added this to the 3.0 milestone Aug 29, 2023

dnenov added 3 commits August 29, 2023 19:11

refactor

758aa75

- replaced boolean propertie representing the new filters with FilterEntity

added tests

d5d69ae

- added tests for the new filters

stylize control components

4f73f1c

- standardized ui element styles

dnenov marked this pull request as ready for review August 30, 2023 08:25

dnenov added 4 commits August 30, 2023 09:25

Merge remote-tracking branch 'upstream/master' into pm-searchforpackages

bf661c0

fixed failing tests

a61315a

Merge remote-tracking branch 'upstream/master' into pm-searchforpackages

1e8d45c

filters context menu stay open

98e211c

- the user will be able to select multiple filters without the context menu closing

QilongTang reviewed Sep 6, 2023

View reviewed changes

src/DynamoCoreWpf/Properties/Resources.resx Show resolved Hide resolved

QilongTang reviewed Sep 7, 2023

View reviewed changes

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs Show resolved Hide resolved

QilongTang reviewed Sep 8, 2023

View reviewed changes

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs Outdated Show resolved Hide resolved

dnenov added 3 commits September 11, 2023 15:43

Merge remote-tracking branch 'upstream/master' into pm-searchforpackages

e50f669

dependency filters toggle active states

6160915

- the two dependency filters (package 'has decency' and 'has no dependency') cannot be both in positive states - adjusted tests to take that change into account

comments

82fba5f

- reverted default sorting back to `LastUpdate`

QilongTang reviewed Sep 11, 2023

View reviewed changes

src/DynamoPackages/PackageManagerSearchElement.cs Outdated Show resolved Hide resolved

QilongTang reviewed Sep 11, 2023

View reviewed changes

src/DynamoCoreWpf/Views/PackageManager/Controls/FilterTagControl.xaml.cs Show resolved Hide resolved

QilongTang reviewed Sep 11, 2023

View reviewed changes

dnenov added 5 commits September 13, 2023 13:25

filter tooltips

1c3c507

- added tooltips for all new filters, - updated old filters, - changed styling

Merge remote-tracking branch 'upstream/master' into pm-searchforpackages

06567b5

reconciling differences

1561f0c

reconciling differences

7b26560

comments for FilterTagControl public properties

080d21f

- added comments for the public properties of the FilterTagControl

reddyashish reviewed Sep 13, 2023

View reviewed changes

src/DynamoCoreWpf/Views/PackageManager/Controls/FilterTagControl.xaml.cs Outdated Show resolved Hide resolved

reddyashish reviewed Sep 13, 2023

View reviewed changes

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs Show resolved Hide resolved

nameof instead of string

68821c5

- replaced hard-coded string value with nameof property

QilongTang reviewed Sep 13, 2023

View reviewed changes

QilongTang approved these changes Sep 13, 2023

View reviewed changes

QilongTang merged commit 9abe5ef into DynamoDS:master Sep 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pm search for packages - filters#14322

Pm search for packages - filters#14322
QilongTang merged 22 commits intoDynamoDS:masterfrom
dnenov:pm-searchforpackages

dnenov commented Aug 25, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QilongTang left a comment •

edited

Loading

Uh oh!

Uh oh!

reddyashish Sep 13, 2023

Uh oh!

Uh oh!

QilongTang Sep 13, 2023

Uh oh!

dnenov Sep 13, 2023

Uh oh!

QilongTang left a comment •

edited

Loading

Uh oh!

dnenov commented Sep 13, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dnenov commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

UI Changes

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QilongTang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

reddyashish Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QilongTang Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

dnenov Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

QilongTang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnenov commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dnenov commented Aug 25, 2023 •

edited

Loading

QilongTang left a comment •

edited

Loading

QilongTang left a comment •

edited

Loading

dnenov commented Sep 13, 2023 •

edited

Loading