Pm mypackages - cherrypick resources#14299
Merged
QilongTang merged 9 commits intoDynamoDS:masterfrom Aug 23, 2023
Merged
Conversation
- merging existing functionality for the package details extension
- added resources for localization - package manager view final changes
- added test for InitialResultsLoaded - removed accidental code
- removed PackageManagerSearchPackagesControlName as no longer needed
- small update to the border thickness - comment added to the new copy-to-clipboard
QilongTang
reviewed
Aug 22, 2023
Contributor
|
I have a question, can we allow upload with version lower like nuget.org ?
|
QilongTang
reviewed
Aug 22, 2023
QilongTang
reviewed
Aug 22, 2023
QilongTang
reviewed
Aug 22, 2023
QilongTang
reviewed
Aug 22, 2023
| }; | ||
|
|
||
| // setting the owner to the packageManagerWindow will centralize promts originating from the Package Manager | ||
| dynamoViewModel.Owner = packageManagerWindow; |
QilongTang
reviewed
Aug 22, 2023
| { | ||
| var tabName = Dynamo.Wpf.Properties.Resources.PreferencesPackageManagerSettingsTab; | ||
| var expanderName = Dynamo.Wpf.Properties.Resources.PackagePathsExpanderName; | ||
| PreferencesPanelUtilities.OpenPreferencesPanel(dynamoView, WindowStartupLocation.CenterOwner, tabName, expanderName); |
Contributor
There was a problem hiding this comment.
Do we do this so it works in a localized environment? But I think it is the other way round right? It would fail that way, did I miss anything here
Contributor
There was a problem hiding this comment.
I can see that you are following an existing example, let's leave it for now
QilongTang
reviewed
Aug 22, 2023
src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Aug 22, 2023
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with some comments
QilongTang
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #14198 to break it down into smaller chunks.
Purpose
This is a follow-up PR on the package integration PR. It builds on the continuous design guides as per this Figma link.
Even though a lot of areas have been improved, this is still work in progress. With the main skeleton of the solution in place, the major directions of work are:
Screenshots
01 loading screen
02 discard loading timeout
03 package details extension interaction
04 package manager contents
05 package manager to preferences interaction
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Progression work on the Package Manager
Reviewers
@reddyashish
@QilongTang
FYIs
@Amoursol