Cherry-Pick Fix Node Autocomplete Regressions#14282
Cherry-Pick Fix Node Autocomplete Regressions#14282QilongTang merged 4 commits intoDynamoDS:RC2.19.0_masterfrom RobertGlobant20:RC2.19.0_master
Conversation
* Fix Node Autocomplete Regressions Due that we are adding ZeroTouchNodes during test mode around 9 tests are failing, seems that there are several nodes duplicates so each test needs to be analyzed separately. Then in this fix I'm reverting the code for adding ZeroTouchNodes and also removing a test that will fail due to this change. * Fix Node Autocomplete Regressions Re-adding unit test with Failure category
| /// This test will validate that the nodes "Input", "Output", "And", "Or", "Not", "+", "-" appear in the InCanvasSearch results | ||
| /// </summary> | ||
| [Test] | ||
| [Category("UnitTests")] |
There was a problem hiding this comment.
@RobertGlobant20 [Category("UnitTests")] should also be present.
There was a problem hiding this comment.
I searched for Failure category in Dynamo solution and in all the places is only Failure, do you have an example of a test with both categories?
e.g.
There was a problem hiding this comment.
You can just add another category attribute like this:
[Test]
[Category("UnitTests")]
[Category("Failure")]
or like this:
https://github.com/DynamoDS/Dynamo/blob/master/test/DynamoCoreTests/UnitsOfMeasureTests.cs#L1047
There was a problem hiding this comment.
@reddyashish ok got your point.
Due that this PR is a cherry-pick, could you approve and merge it? (If I do changes over this branch won't be cherry-picking the commit).
I will do the change in the original branch and then create another cherry-pick PR.
There was a problem hiding this comment.
@RobertGlobant20 This works, will approve and merge
3 participants
Purpose
Cherry-Pick Fix Node Autocomplete Regressions
#14275
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Cherry-Pick Fix Node Autocomplete Regressions
Reviewers
@QilongTang @reddyashish
FYIs