Cherrypicking lucene unit testing#14257
Merged
QilongTang merged 2 commits intoDynamoDS:RC2.19.0_masterfrom Aug 15, 2023
Merged
Conversation
* Lucene unit testing * test updates * Update LuceneSearchUtility.cs * Update NodeAutoCompleteSearchViewModel.cs * Update NodeAutoCompleteSearchViewModel.cs * Test updates (cherry picked from commit 780f854)
Co-authored-by: pinzart <[email protected]> (cherry picked from commit aaf6a4e)
Collaborator
Author
|
@QilongTang Tested that library is loading fine after these changes. |
Contributor
|
Are these regressions expected? @reddyashish Maybe some diff between 2.19 branch and master? |
Collaborator
Author
|
@QilongTang The WPFVisualization tests failing doesn't look related to these changes and Mike mentioned that they are failing due to other changes. https://autodesk.slack.com/archives/C1866AFQB/p1692046172475029 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cherrypicking Lucene unit testing into 2.19 #14214
and #14253 as followup to fix the library.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Cherrypicking lucene unit testing
Reviewers
@QilongTang