PackageManager Lucene Crash#14179
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Jul 21, 2023
RobertGlobant20:PackageManager-LuceneCrash
Merged
PackageManager Lucene Crash#14179QilongTang merged 2 commits intoDynamoDS:masterfrom RobertGlobant20:PackageManager-LuceneCrash
QilongTang merged 2 commits intoDynamoDS:masterfrom
RobertGlobant20:PackageManager-LuceneCrash
Conversation
After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called). Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().
QilongTang
approved these changes
Jul 20, 2023
reddyashish
approved these changes
Jul 20, 2023
Collaborator
|
Looks like there is a failure @RobertGlobant20 ? |
Contributor
Author
@reddyashish seems that there is a problem when parsing the DynamoCoreTestResults.xml file, I don't think this is related to this fix, right?. |
Collaborator
|
yeah, can you trigger a rebuild |
Removing empty space
Contributor
|
@reddyashish @RobertGlobant20 it was a build time out issue, I discussed with Turbo team this morning and we raised the limit |
Contributor
Author
|
@QilongTang @reddyashish most of the checks passed, the only one Pending is SonarQube Scan, not sure why is Pending if I cannot see any task runing for DynamoCACoverage job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing crash after opening and closing the PackageManager
After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called). Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing crash after opening and closing the PackageManager
Reviewers
@QilongTang @reddyashish
FYIs