Documentation browser error message fix#14174
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Jul 18, 2023
Merged
Conversation
- a small fix around a limitation in how warnings were read - now captures the case where a warning does not have an href tag to it - will now display the full multiline text of a warning that does not have an href tag
Contributor
|
@reddyashish a small PR from Deyan adding multi-line support to Error Messages in the Extended Node Help. |
reddyashish
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an issue with the Documentation Browser specifically when displaying a Warning without an "href" tag. Previously, when creating the Warning
messagepart of the help body, we would assume that an "href" tag is present in the second line of the info message. This is not always the case, and as a result any warning message of more than 1 line would be clipped to display only the first line.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@Amoursol
FYIs
@reddyashish