DYN-6037 lucene overloaded nodes#14136
DYN-6037 lucene overloaded nodes#14136QilongTang merged 4 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-6037-Lucene-Overloaded-Nodes
Conversation
Some nodes were missing for the search due that were overloaded so the same node was added several times in the search results without considering the parameters. The fix was indexing also the parameters so when executing the search we need to also match the parameters.
Fixing comment
|
This is a GIF showing the search results after my fix: |
| if (e.Parameters == null) | ||
| return string.IsNullOrEmpty(parameters); | ||
| else | ||
| return e.Parameters.Equals(parameters); |
There was a problem hiding this comment.
Can you put comments for this block, not too intuitive to me
There was a problem hiding this comment.
I've added more comments please let me know if the explanation is clear. Thanks
commit: 6bc39b7
Adding comments for explaining a piece of code.
avidit
changed the title
| @@ -138,7 +143,8 @@ public enum IndexFieldsEnum | |||
| nameof(IndexFieldsEnum.Description), | |||
There was a problem hiding this comment.
Change the Enum name from IndexFieldsEnum to NodeIndexFields, as it is specific to that?
There was a problem hiding this comment.
I've renamed IndexFieldsEnum to NodeIndexFields
commit: fab8b07
There was a problem hiding this comment.
Sorry for the confusion, I just saw that the same enum property is used in PackageIndexFields also and one of the enum values is "Hosts". Not a big deal, you can revert this last name change if you want.
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
Renaming IndexFieldsEnum to NodeFieldsEnum.
|
@RobertGlobant20 can you check if the regressions are real? |
|
Failing test is a ASM loading exception on visualization tests. |
3 participants
Purpose
Fixing Lucene search result for overloaded nodes.
Some nodes were missing for the search due that were overloaded so the same node was added several times in the search results without considering the parameters.
The fix was indexing also the parameters so when executing the search we need to also match the parameters.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Lucene search result for overloaded nodes.
Reviewers
@QilongTang @reddyashish
FYIs