DYN-5821-AddToWorkspace-DocumentationBrowser#14103
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Jun 22, 2023
RobertGlobant20:DYN-5821-AddToWorkspace-DocumentationBrowser
Merged
DYN-5821-AddToWorkspace-DocumentationBrowser#14103QilongTang merged 1 commit intoDynamoDS:masterfrom RobertGlobant20:DYN-5821-AddToWorkspace-DocumentationBrowser
QilongTang merged 1 commit intoDynamoDS:masterfrom
RobertGlobant20:DYN-5821-AddToWorkspace-DocumentationBrowser
Conversation
I've added some validations so when we are trying to insert a xml dyn file graph without notes, inserting doesn't crash (otherwise the graph is not added).
Contributor
Author
QilongTang
approved these changes
Jun 22, 2023
reddyashish
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
Preventing crash when inserting xml dyn graph files into workspace.
I've added some validations so when we are trying to insert a xml dyn file graph without notes, inserting doesn't crash (otherwise the graph is not added).
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Preventing crash when inserting xml dyn graph files into workspace.
Reviewers
@QilongTang @reddyashish
FYIs