Merged
Conversation
pinzart90
requested review from
QilongTang,
mjkkirschner and
zeusongit
and removed request for
zeusongit
QilongTang
reviewed
Jun 16, 2023
| // ALIAS does needs a total network traffic blackout. | ||
| // Since there is no way to switch this on/off, we will just skip it for now. | ||
| /* | ||
| foreach (var pkg in packages) |
Contributor
There was a problem hiding this comment.
This code would not raise network traffic right? This is the code to check if the installed package is targetting other host. I think @zeusongit recently worked on it..
Contributor
Author
There was a problem hiding this comment.
I commented it out because it did try to contact pacakage manager.
I could not find a way to disable through API or configs. @zeusongit any idea if there is a way to disable this ?
Contributor
There was a problem hiding this comment.
After reading the code, I can see why now. In function CheckIfPackagesTargetOtherHosts there is a call var knownHosts = PackageManagerClient.GetKnownHosts(); which will contact package manager
Contributor
There was a problem hiding this comment.
I think this solution is fine for now but we probably want to guard all of these code using the env variable or setting property on master branch.
QilongTang
reviewed
Jun 16, 2023
Contributor
|
Are there code changes related to |
Contributor
Author
Only locally, to reflect the changes in the ALIAS repo |
QilongTang
approved these changes
Jun 16, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Sep 8, 2023
* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]>
mjkkirschner
pushed a commit
that referenced
this pull request
Sep 8, 2023
* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]>
QilongTang
pushed a commit
that referenced
this pull request
Sep 11, 2023
* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Sep 11, 2023
* cherry pick analytics issue (DynamoDS#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (DynamoDS#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (DynamoDS#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
mjkkirschner
added a commit
that referenced
this pull request
Sep 11, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
mjkkirschner
added a commit
that referenced
this pull request
Sep 19, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> * add python tests * move project * revert --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
pinzart90
added a commit
that referenced
this pull request
Oct 28, 2023
* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To achieve network blackout this is what I had to do: