Merged
Conversation
- added white border to preference view to increase visibility
Contributor
|
The reported regression is sporadic failure |
QilongTang
reviewed
Jun 15, 2023
| <Grid x:Name="mainGrid" | ||
| Background="{StaticResource PreferencesWindowBackgroundColor}"> | ||
| <Border x:Name="mainBorder" | ||
| BorderBrush="{StaticResource WorkspaceBackgroundHomeBrush}" |
Contributor
There was a problem hiding this comment.
I guess you happen to found out this color from other places is white?
Collaborator
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Thanks, will merge it for now
QilongTang
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A visual update to the Preferences View adding a white (
WorkspaceBackgroundHomeBrush) 2px border. This should increase the visibility of the control and make it easier for users to make out the actual window when overlapping with other UI elements.Screenshot of changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@Amoursol
@reddyashish
@QilongTang
FYIs