Skip to content

[DYN-5915] Obsolete IronPython2 warning#14040

Merged
zeusongit merged 4 commits intoDynamoDS:masterfrom
zeusongit:remv-pyth-dial
Jun 2, 2023
Merged

[DYN-5915] Obsolete IronPython2 warning#14040
zeusongit merged 4 commits intoDynamoDS:masterfrom
zeusongit:remv-pyth-dial

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented May 31, 2023

Purpose

https://jira.autodesk.com/browse/DYN-5915
Obsolete IronPython2 Warning Dialog
Removed option to toggle warning from preference panel
Removed related tests

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Removed IronPython2 Warning Dialog message

Reviewers

@DynamoDS/dynamo

mjkkirschner
mjkkirschner reviewed May 31, 2023
View reviewed changes
src/DynamoCore/Configuration/PreferenceSettings.cs
/// <summary>
/// This defines if user wants to see the Iron Python Extension Dialog box on every new session.
/// </summary>
public bool IsIronPythonDialogDisabled { get; set; }
Copy link
Member

@mjkkirschner mjkkirschner May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an API break - probably better to obsolete the pref and have it do nothing for now. Even though that might be confusing, it will avoid potential runtime exceptions.

Copy link
Contributor Author

@zeusongit zeusongit Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to keep the view as well?

@QilongTang QilongTang added this to the 2.19.0 milestone Jun 1, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Jun 1, 2023

error CS1566: Error reading resource 'Dynamo.Notifications.Packages.NotificationCenter.build.index.bundle.js' -- 'Could not find a part of the path 'D:\a\Dynamo\Dynamo\Dynamo\src\Notifications\Packages\NotificationCenter\build\index.bundle.js'.' I think this error is because @Enzo707 pushed the wrong version manually, will be fixed by DynamoDS/NotificationCenter#37

@QilongTang
Copy link
Contributor

QilongTang commented Jun 1, 2023

strange that the PR check still failed

@zeusongit
Copy link
Contributor Author

zeusongit commented Jun 2, 2023

strange that the PR check still failed

passed in the latest run

@zeusongit zeusongit merged commit 79bc03e into DynamoDS:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zeusongit @QilongTang @mjkkirschner