Handle TabFolding edge-case inside python editor.#14004
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom May 18, 2023
Merged
Handle TabFolding edge-case inside python editor.#14004QilongTang merged 1 commit intoDynamoDS:masterfrom
QilongTang merged 1 commit intoDynamoDS:masterfrom
Conversation
dnenov
approved these changes
May 18, 2023
Collaborator
dnenov
left a comment
dnenov
left a comment
There was a problem hiding this comment.
Tested on my end, fixes the crash!
QilongTang
approved these changes
May 18, 2023
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
May 18, 2023
(cherry picked from commit 054ef8c)
9 tasks
reddyashish
added a commit
that referenced
this pull request
May 18, 2023
Enzo707
pushed a commit
to Enzo707/Dynamo
that referenced
this pull request
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
As per the crash reported here: https://forum.dynamobim.com/t/dynamo-2-18-release/89667/3, this check should fix the edge case. Will be cherrypicking into 2.18.1 hotfix
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Handle TabFolding edge-case inside python editor.
Reviewers
@QilongTang @dnenov