DYN-5844-ColorPicker-MarginIssues#13986
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom May 12, 2023
RobertGlobant20:DYN-5844-ColorPicker-MarginIssues
Merged
DYN-5844-ColorPicker-MarginIssues#13986reddyashish merged 1 commit intoDynamoDS:masterfrom RobertGlobant20:DYN-5844-ColorPicker-MarginIssues
reddyashish merged 1 commit intoDynamoDS:masterfrom
RobertGlobant20:DYN-5844-ColorPicker-MarginIssues
Conversation
We have a Canvas inside a Grid but the Canvas doesn't support auto-size like other WPF controls then the only way to fix the problem of the CustomColorPicker appearing wrong under a 200% scale is to use a fixed height. In this way this fix will make the NormalColors window with the same height than the CustomColors window.
Contributor
Author
QilongTang
approved these changes
May 12, 2023
Collaborator
|
Failing test is a flaky one: WorkspaceContextMenu_IfSubmenuOpenOnMouseHover |
reddyashish
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
Fixing height value for CustomColorPicker.
We have a Canvas inside a Grid but the Canvas doesn't support auto-size like other WPF controls then the only way to fix the problem of the CustomColorPicker appearing wrong under a 200% scale is to use a fixed height. In this way this fix will make the NormalColors window with the same height than the CustomColors window.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing height value for CustomColorPicker.
Reviewers
@QilongTang
FYIs