DYN-4513 Improvement: Allow pin note to node via drag, hover and release#13966
Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom May 9, 2023
Merged
Conversation
- will highlight Node when a Note is being hovered over it
- moved the new functionality into a separate method, as it was getting a bit too long - now only handles the case of a note being dragged over a node
- now successfully pins the note when the mouse is released and the note is over the node - will skip highlighting Nodes that already have a Note pinned (consistent with current behavior to not allow more than 1 pinned Note)
reddyashish
approved these changes
May 9, 2023
Collaborator
|
The failing test is a flaky one. We will need a UI automation test for this feature. Will add a task for that and merging this. |
Contributor
|
@reddyashish did this make it into 2.18, or is it targeted for 2.19? |
Collaborator
|
This is in 2.19 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
An improvement allowing the user to drag-&-drop a Note over a Node, pinning it down. Below is the description of the task as set in the brief:
pin note to node
border update on hover state
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
The steps taken to create the new functionality are as follows:
Reviewers
@reddyashish
@Amoursol
FYIs