implement new token interface#13917
Merged
mjkkirschner merged 3 commits intoDynamoDS:masterfrom Apr 24, 2023
Merged
Conversation
reddyashish
approved these changes
Apr 20, 2023
aparajit-pratap
approved these changes
Apr 21, 2023
Member
Author
|
@zeusongit - I notice that this failure occurred AFTER I merged your changes, and I also noticed that these tests actually put real load on the package manager to get the hosts lists - if for some reason the package manager returns an empty list or times out during a test run, the garbage value may now be cached. I've only seen it infrequently, but perhaps we should either make the cache short lived, only cache if the result is not garbage, and in addition make these tests use mocks. |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Apr 26, 2023
* implement new interface * update to released greg
QilongTang
pushed a commit
that referenced
this pull request
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
depends on this PR:
DynamoDS/PackageManagerClient#80
implement new interface
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
make single sign on usable from graphs
Reviewers